feature: support hiding empty services #1264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2023-09-28 17:21:14: =========TEST START========== |
|
@chuntaojun 大佬有空帮忙review下 |
chuntaojun
reviewed
Oct 12, 2023
| if hideEmptyService { | ||
| nonEmptyServices := make([]*model.EnhancedService, 0, len(services)) | ||
| for _, service := range services { | ||
| if service.HealthyInstanceCount > 0 { |
There was a problem hiding this comment.
参数描述和实际逻辑不符合，建议改为 only_exist_healthyinstance
There was a problem hiding this comment.
这个查询逻辑应该放在 s.caches.Service().GetServicesByFilter 里面，否则你这个查询是有问题的
chuntaojun
suggested changes
Oct 16, 2023
| @@ -156,6 +159,9 @@ func EnrichGetServicesApiDocs(r *restful.RouteBuilder) *restful.RouteBuilder { | |||
| " 和 instance_values 需要同时填写且必须元素个数一致"). | |||
| DataType(typeNameString). | |||
| Required(false)). | |||
| Param(restful.QueryParameter("hide_empty_service", "隐藏空服务").DataType(typeNameBool). | |||
| if hideEmptyService { | ||
| nonEmptyServices := make([]*model.EnhancedService, 0, len(services)) | ||
| for _, service := range services { | ||
| if service.HealthyInstanceCount > 0 { |
There was a problem hiding this comment.
这个查询逻辑应该放在 s.caches.Service().GetServicesByFilter 里面，否则你这个查询是有问题的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide issue(s) of this PR:
Fixes #1182 #1133
polaris-console相关的PR：
polarismesh/polaris-console#247
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.